-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n: Create a JSON subtitle format for translating via Crowdin #2644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to be tricky...
- remove the need for the groups file - support the json format end to end (parsing it) - merge identical metadata or subtitles (uk english) to reduce duplication - remove GOAL deserialization code - update subtitle editor a bit
… such to it later
xTVaser
force-pushed
the
v/subtitle-format
branch
from
May 14, 2023 23:44
bc147c2
to
7bd6d23
Compare
xTVaser
force-pushed
the
v/subtitle-format
branch
from
May 14, 2023 23:55
fb4b562
to
f3a914e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty close, main thing i have to do is update the subtitle editor.Subtitle editor mostly works / doesn't crash at least -- but I'll follow up later to clean up the UI. Doesn't feel like a huge priority because the only language that would use it at this point would be japanese.
The plan is to allow translating subtitles via Crowdin for only the languages that don't have an audio accompaniment. Which is fine, because in later games the subtitles for those languages are done for us and Jak 1 is already well translated in this regard (except for japanese). This limitation is because it's just too hard to support distributed translation when different timings / line amounts are involved.
Typically subtitles are done with an SRT file, which is very similar in terms of features as ours -- you have a timestamp and text to display at that timestamp. But this breaks down if different languages change the timings, or split/merge captions. This would never happen in a traditional subtitle setting because you'd be subtitling the same audio, but the game has multiple sets of audio unfortunately.
This new format does a few key things: